[2.9] Ensure all DB errors when inserting logs are always logged to logsink #13098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves visibility in cases such as LP1930899 where underprovisioned mongodb instance prevented log entries from being persisted with no additional error output. As the DB error was returned back to the caller (log sender worker), the worker would keep restarting thus preventing models from logging anything. While this commit does not fix the underlying problem (underprovisioned mongo) it should at least make the cause of the problem more obvious to users that are trying to diagnose similar issues by inspecting the logsink.log file contents.
SimonRichardson
approved these changes
Jun 22, 2021
|
|
jujubot
added a commit
that referenced
this pull request
Jun 28, 2021
#13109 Merge from 2.9 to bring forward: - #13103 from manadart/2.9-lxd-spec-assignment - #13105 from ycliuhw/fix/lp-1929904 - #13106 from SimonRichardson/update-http-dep - #13100 from tlm/model-operator-29-upgrade - #13102 from manadart/2.9-lxd-with-proxy - #13099 from SimonRichardson/updating-packaging-dep - #13096 from ycliuhw/lp-1927656 - #13101 from hpidcock/aws-encrypted-ebs - #13073 from tlm/LP1930798-juju-2.9-k8s-upgrade-2 - #13078 from hmlanigan/sidecar-charm-via-bundle - #13098 from achilleasa/2.9-logsink-error-if-persisting-logs-to-db-fails - #13091 from wallyworld/use-aws-sdk-v2 - #13095 from jujubot/increment-to-2.9.7 Conflicts: - caas/kubernetes/provider/export_test.go - cmd/juju/application/deployer/bundlehandler.go - cmd/juju/application/deployer/deployer.go - core/bundle/changes/handlers.go - core/charm/computedseries.go - go.mod - go.sum - scripts/win-installer/setup.iss - snap/snapcraft.yaml - version/version.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward port of #13097 to 2.9
Bug reference
https://bugs.launchpad.net/juju/+bug/1930899
(NOTE: the PR does not fix ^ but helps diagnose the root cause of the issue)