-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in cluster credentials for juju upgrades. #13073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm
force-pushed
the
LP1930798-juju-2.9-k8s-upgrade-2
branch
from
June 21, 2021 04:16
1a3c9bd
to
d18bb64
Compare
hpidcock
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of changes but looks good.
tlm
force-pushed
the
LP1930798-juju-2.9-k8s-upgrade-2
branch
2 times, most recently
from
June 22, 2021 04:26
cce67d9
to
ebfd59c
Compare
|
tlm
force-pushed
the
LP1930798-juju-2.9-k8s-upgrade-2
branch
from
June 22, 2021 21:24
ebfd59c
to
ce315ec
Compare
In juju 2.9 we migrated the controller pod to using in cluster credentials when talking to Kubernetes. This change did not apply to upgrade controllers. This commit changes that with upgrade steps to the controller. Fixes LP1930798
tlm
force-pushed
the
LP1930798-juju-2.9-k8s-upgrade-2
branch
from
June 22, 2021 21:25
ce315ec
to
166f8ab
Compare
|
jujubot
added a commit
that referenced
this pull request
Jun 28, 2021
#13109 Merge from 2.9 to bring forward: - #13103 from manadart/2.9-lxd-spec-assignment - #13105 from ycliuhw/fix/lp-1929904 - #13106 from SimonRichardson/update-http-dep - #13100 from tlm/model-operator-29-upgrade - #13102 from manadart/2.9-lxd-with-proxy - #13099 from SimonRichardson/updating-packaging-dep - #13096 from ycliuhw/lp-1927656 - #13101 from hpidcock/aws-encrypted-ebs - #13073 from tlm/LP1930798-juju-2.9-k8s-upgrade-2 - #13078 from hmlanigan/sidecar-charm-via-bundle - #13098 from achilleasa/2.9-logsink-error-if-persisting-logs-to-db-fails - #13091 from wallyworld/use-aws-sdk-v2 - #13095 from jujubot/increment-to-2.9.7 Conflicts: - caas/kubernetes/provider/export_test.go - cmd/juju/application/deployer/bundlehandler.go - cmd/juju/application/deployer/deployer.go - core/bundle/changes/handlers.go - core/charm/computedseries.go - go.mod - go.sum - scripts/win-installer/setup.iss - snap/snapcraft.yaml - version/version.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In juju 2.9 we migrated the controller pod to using in cluster
credentials when talking to Kubernetes. This change did not apply to
upgrade controllers. This commit changes that with upgrade steps to the
controller.
Checklist
QA steps
See bug. We want to do an upgrade from 2.8 to 2.9 and check that the statefulset for the controller gets it's service account attached and that the controller logs report no provider errors for credentials.
Bug reference
https://bugs.launchpad.net/juju/+bug/1930798