Integration fixes #12831
Merged
Integration fixes #12831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed fix for getting better logging messages when running integration tests.
SimonRichardson
force-pushed
the
static-test-fixes
branch
from
aa46ac0 to
1930e5b
Compare
The following just ensures we're consistent with the common set of includes.
One issue we have currently is when developing locally it's hard to know what's being run and where the error arises. The following changes that by launching a background process that tails the current test log and just renders that to stdout/stderr if you have -v enabled. The good thing with this, is that we get to keep backwards compatibility by ensuring that we keep the test lof file around for archiving.
hmlanigan
reviewed
Apr 12, 2021
There was a problem hiding this comment.
QA with (cd tests && ./main.sh -v charmhub)
The farther along in the test run, the more times a log line was repeated. 1, to 2, to 3 and finally 10: https://pastebin.canonical.com/p/zQWgw9ZnNC/
In the pastern, some output is done wrong in the scripts, though unrelated to this PR I believe. E.g Success: "%s" > "%s" 4 0 instead of Success: 4 > 0
No issues with (cd tests && ./main.sh smoke) or (cd tests && ./main.sh -v deploy) that jumped out.
hmlanigan
reviewed
Apr 12, 2021
Turns out tail wasn't killing itself correctly everytime with a SIGINT, instead we should kill it with fire.
@hmlanigan fixed that as well, in the last commit. |
|
====> Destroyed juju model test-charmhub-info |
hmlanigan
approved these changes
Apr 14, 2021
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Apr 21, 2021
#12909 Merge 2.9 #12827 Unsubscribe from hub when closing state pool #12829 Correct default bootstrap-timeout value displayed in help. #12840 Constraint tags can be used for pod affinity #12842 Fix upgrade series agent version handling #12794 Add disk provisioning customization #12845 Restore space support for manual machines #12839 Support merging of netplan configs #12853 Add display type for network-get results #12854 Fix for LP1921557 sni in Juju login. #12850 Use Base in Charmhub packge and its response structures. #12858 Ensure assess-upgrade-series does not report started prematuremly #12860 Removed logging from core annotations. #12861 Fixes bug where empty error can happen in storage #12865 Update Pebble version to include new files API #12866 Workaround for k8s dashboard URL with k8s client proxy #12862 Fix/lp 1923051 #12867 Fix/lp 1923561 #12870 Use channel logic in charm library #12873 Add support for setting pod affinity topology key #12874 Use Patch instead of Update for ensuring ingress resources #12831 Integration fixes #12879 Ensure refresh uses version #12864 bug: fix for bootstrap fail on vsphere 7 + multi network #12883 Initial work to allow juju trust for sidecar charms #12884 Fix ssh with sidecar charms and containers. #12886 Charmhub bases #12881 Use charm pkg updates #12889 Ignore projected volume mounts when looking up juju storage #12890 Fix passing empty string container name to unit params #12893 Add CLA checker GH action and remove codecov push action #12897 Use production charmhub endpoint #12887 Resource validation error #12888 Ensure we validate the model target #12898 Remove usage of systems package from CAAS application provisioner #12899 CAAS bundle deployments #12900 Bump up Pebble version to include user/group in list-files #12901 charm Format helper #12902 charm Iskubernetes helper #12903 Display ... for really long k8s app versions in status #12904 Filter out more full registry paths for app version in status #12905 Fix k8s bundle deploys with v2 charms #12906 Register resource-get for containeragent binary Conflicts mostly due to charm v8 vs v9 imports. The other one was due to changes to dashboard CLI. ``` # Conflicts: # api/common/charms/common.go # api/common/charms/common_test.go # apiserver/facades/client/application/application.go # apiserver/facades/client/application/charmstore.go # apiserver/facades/client/application/update_series_mocks_test.go # apiserver/facades/client/charms/client.go # apiserver/facades/client/charms/convertions.go # apiserver/facades/client/machinemanager/types_mock_test.go # apiserver/facades/controller/caasoperatorprovisioner/provisioner.go # cmd/juju/application/deployer/bundlehandler_test.go # cmd/juju/application/refresh_test.go # cmd/juju/application/refresher/refresher_mock_test.go # cmd/juju/dashboard/dashboard.go # core/charm/strategies_mock_test.go # core/model/model.go # core/model/model_test.go # go.mod # go.sum # resource/resourceadapters/charmhub.go # scripts/win-installer/setup.iss # service/agentconf_test.go # snap/snapcraft.yaml # state/charm.go # state/migration_export.go # state/state.go # version/version.go # worker/caasfirewallerembedded/applicationworker.go # worker/caasfirewallerembedded/applicationworker_test.go ``` ## QA steps See PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes ensure that the verbose setting when running
the integration tests to allow the real-time viewing of what's being currently
run. Previously this was hidden until the very end of the test, which made
it really hard to develop against it locally when you have long integration
tests.
The code is simple, send the logs to a file and then using a background
process, just tail the log file. Although simple, it wasn't easy to get right
as first, as we had to ensure backward compatibility and ensure that
pipefail worked as designed.
As a driveby I fixed the inconsistency issue of one bracket vs two, now
that we're using bash.
QA steps
Without verbose, this should be rather quiet:
(cd tests && ./main.sh smoke)With verbose this should be really chatty:
(cd tests && ./main.sh -v smoke)