Test Verification for ProvisionerTask Worker Stoppage After Error #11146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleasa
reviewed
Jan 23, 2020
|
|
||
| res := make(chan error) | ||
| go func() { | ||
| res <- task.Wait() |
There was a problem hiding this comment.
DirtyKill always makes Wait return right?
There was a problem hiding this comment.
It's the same as CleanKill (will time-out with an error if wait does not return), but ignores the error.
Actually this means it can be done in simpler fashion; stand by.
achilleasa
approved these changes
Jan 23, 2020
manadart
force-pushed
the
2.7-provisioner-worker-test
branch
from
39e9bf7 to
ead1d6f
Compare
stoppage when an error is returned by populateAvailabilityZoneMachines. Always add a test for in-theatre bugs previously uncovered.
manadart
force-pushed
the
2.7-provisioner-worker-test
branch
from
ead1d6f to
c45955f
Compare
|
|
jujubot
added a commit
that referenced
this pull request
Jan 26, 2020
#11151 ### Checklist - [x] Checked if it requires a [pylibjuju](https://github.com/juju/python-libjuju) change? - [x] Added [integration tests](https://github.com/juju/juju/tree/develop/tests) for the PR? - [x] Added or updated [doc.go](https://discourse.jujucharms.com/t/readme-in-packages/451) related to packages changed? - [x] Do comments answer the question of why design decisions were made? ---- ## Description of change This pulls the latest changes in the 2.7 branch into develop. Brings in: - #11139 from jameinel/2.7-detach-volume-state-changing-1860542 - #11141 from howbazaar/2.7-fix-provisioner-leak - #11144 from babbageclunk/2.7-fix-destroy-test - #11137 from ycliuhw/feature/vSphere-disk-resizing - #11146 from manadart/2.7-provisioner-worker-test - #11147 from manadart/relocate-systemd-files - #11150 from manadart/2.7-controller-integration-test - #11149 from manadart/2.7-systemd-upgrades (No conflicts when merging.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This patch simply adds a unit test to verify the change made in #11141.
It should be a golden rule that where we fix a bug from the field for functionality without test coverage, that coverage gap is closed.
QA steps
Unit tests fail sans #11141, but pass with it applied.
Documentation changes
None.
Bug reference
N/A