Feature/vsphere disk resizing #11137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycliuhw
force-pushed
the
feature/vSphere-disk-resizing
branch
from
83d653b to
d7c8ac2
Compare
babbageclunk
approved these changes
Jan 23, 2020
| @@ -398,7 +398,7 @@ func (c *Client) extendVMRootDisk( | |||
| sizeMB uint64, | |||
| taskWaiter *taskWaiter, | |||
| ) error { | |||
| disk, backing, err := c.getDiskWithFileBacking(ctx, vm) | |||
| disk, _, err := c.getDiskWithFileBacking(ctx, vm) | |||
There was a problem hiding this comment.
Might as well change this method to getDisk and drop the backing return value, it doesn't look like anything else uses it.
…t need this permission anymore;
|
!!build!! |
|
|
jujubot
added a commit
that referenced
this pull request
Jan 26, 2020
#11151 ### Checklist - [x] Checked if it requires a [pylibjuju](https://github.com/juju/python-libjuju) change? - [x] Added [integration tests](https://github.com/juju/juju/tree/develop/tests) for the PR? - [x] Added or updated [doc.go](https://discourse.jujucharms.com/t/readme-in-packages/451) related to packages changed? - [x] Do comments answer the question of why design decisions were made? ---- ## Description of change This pulls the latest changes in the 2.7 branch into develop. Brings in: - #11139 from jameinel/2.7-detach-volume-state-changing-1860542 - #11141 from howbazaar/2.7-fix-provisioner-leak - #11144 from babbageclunk/2.7-fix-destroy-test - #11137 from ycliuhw/feature/vSphere-disk-resizing - #11146 from manadart/2.7-provisioner-worker-test - #11147 from manadart/relocate-systemd-files - #11150 from manadart/2.7-controller-integration-test - #11149 from manadart/2.7-systemd-upgrades (No conflicts when merging.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following details to expedite Pull Request review:
Checklist
Description of change
Changed to use
ReconfigureAPI for disk resizing;QA steps
Documentation changes
No(Internal change);
Bug reference
No