fix: onToken to not stop tokenizer sending data to tokenParser

juanjoDiaz · Jul 26, 2023 · 3d1bcaa · 3d1bcaa
1 parent 5b0e267
commit 3d1bcaa
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/packages/plainjs/dist/deno/jsonparser.ts b/packages/plainjs/dist/deno/jsonparser.ts
@@ -39,7 +39,10 @@ export default class JSONParser {
   }
 
   public set onToken(cb: (parsedTokenInfo: ParsedTokenInfo) => void) {
-    this.tokenizer.onToken = cb;
+    this.tokenizer.onToken = (parsedToken) => {
+      cb(parsedToken);
+      this.tokenParser.write(parsedToken);
+    };
   }
 
   public set onValue(cb: (parsedElementInfo: ParsedElementInfo) => void) {

diff --git a/packages/plainjs/src/jsonparser.ts b/packages/plainjs/src/jsonparser.ts
@@ -39,7 +39,10 @@ export default class JSONParser {
   }
 
   public set onToken(cb: (parsedTokenInfo: ParsedTokenInfo) => void) {
-    this.tokenizer.onToken = cb;
+    this.tokenizer.onToken = (parsedToken) => {
+      cb(parsedToken);
+      this.tokenParser.write(parsedToken);
+    };
   }
 
   public set onValue(cb: (parsedElementInfo: ParsedElementInfo) => void) {

diff --git a/packages/plainjs/test/callbacks.ts b/packages/plainjs/test/callbacks.ts
@@ -38,6 +38,19 @@ describe("callback", () => {
     }
   });
 
+  test("should emit onValue callback when the onToken callback is also set", () => {
+    const p = new JSONParser();
+
+    const onValueCb = jest.fn(() => {
+      /* Do nothing */
+    });
+    p.onValue = onValueCb;
+
+    p.write('"test"');
+    expect(onValueCb.mock.calls).toHaveLength(1);
+    expect((onValueCb.mock.calls[0] as any)[0].value).toBe("test");
+  });
+
   test("should handle invalid input using the onError callback if set", () => {
     const p = new JSONParser();
     p.onValue = () => {