perf: use an array to avoid string concats

juanjoDiaz · Jul 26, 2023 · 5b0e267 · 5b0e267
1 parent d61d9bc
commit 5b0e267
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/plainjs/dist/deno/utils/bufferedString.ts b/packages/plainjs/dist/deno/utils/bufferedString.ts
@@ -8,26 +8,26 @@ export interface StringBuilder {
 
 export class NonBufferedString implements StringBuilder {
   private decoder = new TextDecoder("utf-8");
-  private string = "";
+  private strings: Array<string> = [];
   public byteLength = 0;
 
   public appendChar(char: number): void {
-    this.string += String.fromCharCode(char);
+    this.strings.push(String.fromCharCode(char));
     this.byteLength += 1;
   }
 
   public appendBuf(buf: Uint8Array, start = 0, end: number = buf.length): void {
-    this.string += this.decoder.decode(buf.subarray(start, end));
+      this.strings.push(this.decoder.decode(buf.subarray(start, end)));
     this.byteLength += end - start;
   }
 
   public reset(): void {
-    this.string = "";
+    this.strings = [];
     this.byteLength = 0;
   }
 
   public toString(): string {
-    return this.string;
+    return this.strings.join('');
   }
 }
 

diff --git a/packages/plainjs/src/utils/bufferedString.ts b/packages/plainjs/src/utils/bufferedString.ts
@@ -8,26 +8,26 @@ export interface StringBuilder {
 
 export class NonBufferedString implements StringBuilder {
   private decoder = new TextDecoder("utf-8");
-  private string = "";
+  private strings: Array<string> = [];
   public byteLength = 0;
 
   public appendChar(char: number): void {
-    this.string += String.fromCharCode(char);
+    this.strings.push(String.fromCharCode(char));
     this.byteLength += 1;
   }
 
   public appendBuf(buf: Uint8Array, start = 0, end: number = buf.length): void {
-    this.string += this.decoder.decode(buf.subarray(start, end));
+    this.strings.push(this.decoder.decode(buf.subarray(start, end)));
     this.byteLength += end - start;
   }
 
   public reset(): void {
-    this.string = "";
+    this.strings = [];
     this.byteLength = 0;
   }
 
   public toString(): string {
-    return this.string;
+    return this.strings.join("");
   }
 }