Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplification of native method signatures #2047

Closed
markelog opened this issue Jan 29, 2015 · 1 comment
Closed

Simplification of native method signatures #2047

markelog opened this issue Jan 29, 2015 · 1 comment
Assignees
@markelog
Labels
Feature
Milestone
1.12.0/2.2.0

Comments

@markelog
Copy link
Member

Prime candidates, at the moment, are addEventListener third argument for master branch and second argument of getComputedStyle for both branches.

See #1842 (comment)
@markelog markelog added Feature and removed Feature labels Jan 29, 2015
@markelog markelog mentioned this issue Jan 29, 2015
Merged
@mgol
Copy link
Member

mgol commented Feb 4, 2015

addEventListener third argument for master

Why just master? The only difference between branches is IE8 which obviously doesn't go through the addEventListener path.

@mgol mgol added this to the 3.0.0 milestone Feb 4, 2015
@markelog markelog self-assigned this Mar 8, 2015
markelog added a commit to markelog/jquery that referenced this issue Mar 8, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
dd4d68c 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref jquery#2047
markelog added a commit to markelog/jquery that referenced this issue Mar 8, 2015
@markelog
Event: remove extensive checks for "originalEvent" property
b6de0ce 
Support for native methods of the affected code-paths exist in supported
browsers, nevertheless, those are risky changes.

Ref jquery#2047
markelog added a commit to markelog/jquery that referenced this issue Mar 8, 2015
@markelog
Event: add support comment
a51a903 
Ref jquery#2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
d89b82d 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref jquery#2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Event: remove extensive checks for "originalEvent" property
a93411c 
Support for native methods of the affected code-paths exist in supported
browsers, nevertheless, those are risky changes.

Ref jquery#2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Event: add support comment
3d29466 
Ref jquery#2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
71c7db8 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Event: remove extensive checks for "originalEvent" property
4c31839 
Support for native methods of the affected code-paths exist in supported
browsers, nevertheless, those are risky changes.

Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Event: add support comment
e5870cb 
Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Ajax: remove "onunload" event handler
69df0ce 
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Traversing: use Element#children property
2eaae1b 
Ref b734666
Ref 65bdfbf
Closes jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Ajax: remove "onunload" event handler
caa6eab 
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Ajax: remove "onunload" event handler
6b8162e 
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Event: add support comment
92b4137 
Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015
@markelog
Ajax: remove "onunload" event handler
6173880 
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 3, 2015
@markelog
Event: add support comment
fe17cf1 
Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 3, 2015
@markelog
Ajax: remove "onunload" event handler
4c5ff6d 
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 3, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
4cc7f36 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015
@markelog
Event: add support comment
7f96086 
Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015
@markelog
Ajax: remove "onunload" event handler
23cac12 
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
8e50da2 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref jquerygh-2047
markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015
@markelog
Event: remove redundant guards for the event methods
c1eccfc 
Fixes jquerygh-2047
markelog added a commit that referenced this issue May 3, 2015
@markelog
Event: add support comment
0fc5beb 
(cherry-picked from 9db9316)

Ref gh-2047
markelog added a commit that referenced this issue May 3, 2015
@markelog
Ajax: remove "onunload" event handler
4632e55 
Remove hack for IE lost connections, update for it was released
by Microsoft at November 12, 2013.
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047
Ref a117dd0
markelog added a commit that referenced this issue May 3, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
49bce47 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047
Ref 85577a3
markelog added a commit that referenced this issue May 3, 2015
@markelog
Event: add support comment
9db9316 
Ref gh-2047
markelog added a commit that referenced this issue May 3, 2015
@markelog
Ajax: remove "onunload" event handler
a117dd0 
Remove hack for IE lost connections, update for it was released
by Microsoft at November 12, 2013.
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047
markelog added a commit that referenced this issue May 3, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
85577a3 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047
markelog added a commit that referenced this issue Nov 10, 2015
@markelog
Event: add support comment
d46a15d 
Ref gh-2047
markelog added a commit that referenced this issue Nov 10, 2015
@markelog
Ajax: remove "onunload" event handler
9aa1a87 
Remove hack for IE lost connections, update for it was released
by Microsoft at November 12, 2013.
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047
markelog added a commit that referenced this issue Nov 10, 2015
@markelog
Core:CSS:Event: simplification of native method signatures
0cde9bf 
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047
markelog added a commit that referenced this issue Nov 10, 2015
@markelog
Event: remove redundant guards for the event methods
b4be64d 
Fixes gh-2047
Closes gh-2125
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markelog markelog

Labels
Feature
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
4 participants
@dmethvin @timmywil @markelog @mgol