Core:CSS:Event: simplification of native method signatures

markelog · markelog · commit 85577a348a72 · 2015-05-03T13:56:32.000+03:00
* Remove third argument from "addEventListener" * Remove third argument from "removeEventListener" * Remove second argument from "getComputedStyle" Ref gh-2047
diff --git a/src/core/ready.js b/src/core/ready.js
@@ -63,8 +63,8 @@ jQuery.extend({
  * The ready event handler and self cleanup method
  */
 function completed() {
-	document.removeEventListener( "DOMContentLoaded", completed, false );
-	window.removeEventListener( "load", completed, false );
+	document.removeEventListener( "DOMContentLoaded", completed );
+	window.removeEventListener( "load", completed );
 	jQuery.ready();
 }
 
@@ -85,10 +85,10 @@ jQuery.ready.promise = function( obj ) {
 		} else {
 
 			// Use the handy event callback
-			document.addEventListener( "DOMContentLoaded", completed, false );
+			document.addEventListener( "DOMContentLoaded", completed );
 
 			// A fallback to window.onload, that will always work
-			window.addEventListener( "load", completed, false );
+			window.addEventListener( "load", completed );
 		}
 	}
 	return readyList.promise( obj );
diff --git a/src/css/support.js b/src/css/support.js
@@ -39,7 +39,7 @@ define([
 		div.innerHTML = "";
 		documentElement.appendChild( container );
 
-		var divStyle = window.getComputedStyle( div, null );
+		var divStyle = window.getComputedStyle( div );
 		pixelPositionVal = divStyle.top !== "1%";
 		boxSizingReliableVal = divStyle.height === "4px";
 		pixelMarginRightVal = divStyle.marginRight === "4px";
@@ -90,7 +90,7 @@ define([
 			div.style.width = "1px";
 			documentElement.appendChild( container );
 
-			ret = !parseFloat( window.getComputedStyle( marginDiv, null ).marginRight );
+			ret = !parseFloat( window.getComputedStyle( marginDiv ).marginRight );
 
 			documentElement.removeChild( container );
 			div.removeChild( marginDiv );
diff --git a/src/css/var/getStyles.js b/src/css/var/getStyles.js
@@ -4,9 +4,9 @@ define(function() {
 		// IE throws on elements created in popups
 		// FF meanwhile throws on frame elements through "defaultView.getComputedStyle"
 		if ( elem.ownerDocument.defaultView.opener ) {
-			return elem.ownerDocument.defaultView.getComputedStyle( elem, null );
+			return elem.ownerDocument.defaultView.getComputedStyle( elem );
 		}
 
-		return window.getComputedStyle( elem, null );
+		return window.getComputedStyle( elem );
 	};
 });
diff --git a/src/event.js b/src/event.js
@@ -123,7 +123,7 @@ jQuery.event = {
 					special.setup.call( elem, data, namespaces, eventHandle ) === false ) {
 
 					if ( elem.addEventListener ) {
-						elem.addEventListener( type, eventHandle, false );
+						elem.addEventListener( type, eventHandle );
 					}
 				}
 			}
@@ -631,9 +631,10 @@ jQuery.event = {
 };
 
 jQuery.removeEvent = function( elem, type, handle ) {
+
 	// This "if" is needed for plain objects
 	if ( elem.removeEventListener ) {
-		elem.removeEventListener( type, handle, false );
+		elem.removeEventListener( type, handle );
 	}
 };
 

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ jQuery.event = {`
`123`	`123`	`special.setup.call( elem, data, namespaces, eventHandle ) === false ) {`
`124`	`124`
`125`	`125`	`if ( elem.addEventListener ) {`
`126`		`- elem.addEventListener( type, eventHandle, false );`
	`126`	`+ elem.addEventListener( type, eventHandle );`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`	`}`
`@@ -631,9 +631,10 @@ jQuery.event = {`
`631`	`631`	`};`
`632`	`632`
`633`	`633`	`jQuery.removeEvent = function( elem, type, handle ) {`
	`634`	`+`
`634`	`635`	`// This "if" is needed for plain objects`
`635`	`636`	`if ( elem.removeEventListener ) {`
`636`		`- elem.removeEventListener( type, handle, false );`
	`637`	`+ elem.removeEventListener( type, handle );`
`637`	`638`	`}`
`638`	`639`	`};`
`639`	`640`