Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated proto should be checked only for PropertyDefinition with PropertyName. #1228

Closed
wants to merge 1 commit into from
Closed

Duplicated proto should be checked only for PropertyDefinition with PropertyName. #1228

wants to merge 1 commit into from

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Jul 9, 2015

Other PropertyDefinition productions, such as MethodDefinition and
IdentifierReference, should be excluded from duplicated __proto__ checks.

Fixes #1225

@ariya
Duplicated proto should be checked only for PropertyDefinition with P…
ee8a8da 
…ropertyName.

Other PropertyDefinition productions, such as MethodDefinition and
IdentifierReference, should be excluded from duplicated __proto_ checks.

Fixes jquery#1225
@ikarienator
Copy link
Contributor

LGTM 👍 !

@ariya ariya closed this in 495b298 Jul 9, 2015
@ariya ariya deleted the duplicate-proto branch July 17, 2015 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariya @ikarienator @jquerybot