Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure a comma between imported default binding and named imports. #1221

Closed
wants to merge 1 commit into from
Closed

Ensure a comma between imported default binding and named imports. #1221

wants to merge 1 commit into from

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Jul 2, 2015

Fixes #1046

@mikesherov
Copy link
Member

Looks like you added 2 throws, but only 1 test which I assume is the cause of the coverage regression. Otherwise, nice work!

@ariya
Copy link
Contributor Author

ariya commented Jul 2, 2015

Looks like you added 2 throws, but only 1 test which I assume is the cause of the coverage regression.

I intentionally wanted to test Coverall's regression warning but looks like it didn't properly kick in and give the warning :-(

In all cases, I'm adding the extra right away.

@ariya ariya closed this in 6bd50a2 Jul 3, 2015
@ariya ariya deleted the import-comma branch July 5, 2015 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariya @mikesherov @jquerybot