'import foo { bar } from "bar";' should trigger an error #1046

ariya · 2015-02-16T16:41:06Z

The production import foo { bar } from "bar"; is an invalid production, but parses as if it were import foo, { bar } from "bar";, a valid production. (Note the extra comma after the identifier foo.)

Visualization of error:

import foo, { bar } from "bar"; // correct
import foo  { bar } from "bar"; // incorrect
          ^ comma must be required here, yet is automatically inserted.

Affects harmony branch at top of master.

(Migrated from https://code.google.com/p/esprima/issues/detail?id=610, as filed by @IMPinball)

The text was updated successfully, but these errors were encountered:

Fixes jquery#1046

ariya added es6modules defect es6 and removed es6modules labels Feb 16, 2015

ariya added a commit to ariya/esprima that referenced this issue Jul 2, 2015

Ensure a comma between imported default binding and named imports.

d43715b

Fixes jquery#1046

ariya mentioned this issue Jul 2, 2015

Ensure a comma between imported default binding and named imports. #1221

Closed

ariya self-assigned this Jul 2, 2015

ariya added a commit to ariya/esprima that referenced this issue Jul 3, 2015

Ensure a comma between imported default binding and named imports.

e720228

Fixes jquery#1046

ariya added a commit to ariya/esprima that referenced this issue Jul 3, 2015

Ensure a comma between imported default binding and named imports.

cf44b29

Fixes jquery#1046

ariya closed this as completed in 6bd50a2 Jul 3, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

'import foo { bar } from "bar";' should trigger an error #1046

'import foo { bar } from "bar";' should trigger an error #1046

ariya commented Feb 16, 2015

'import foo { bar } from "bar";' should trigger an error #1046

'import foo { bar } from "bar";' should trigger an error #1046

Comments

ariya commented Feb 16, 2015