Run the tests of downstream projects. #1206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reasons, Travis CI complains with when running |
|
Until the mystery with escodegen is resolved, I've removed it and substituted with js2coffee for the time being. |
|
Last status: build with io.js still fails, let me restart the build and see what happens. |
|
Travis CI is still failing. I'm going to restrict this downstream test run only to Node.js 0.12. |
This is done by checking out each project, run npm install, drop-in a replacement for esprima.js, and run npm test. As of now, this is carried out only as part of Travis CI build. It can be tested manually by: rm -rf downstream npm run downstream Due to some unknown reason, .eslintrc can't exist otherwise it is going to confuse the linting of the downstream project. The workaround is to use custom config file. Refs jquery#1023
|
Any reviewer? @ikarienator @mikesherov |
|
👀 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by checking out each project, run npm install, drop-in a
replacement for esprima.js, and run npm test. As of now, this is carried
out only as part of Travis CI build. It can be tested manually by:
Due to some unknown reason, .eslintrc can't exist otherwise it is going
to confuse the linting of the downstream project. The workaround is to
use custom config file.
Refs #1023