-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As part of CI, run the test suite of major downstream projects #1023
Comments
As long eslint is using espree, it won't be easy (requires some tweaking). |
The parser is configurable: http://eslint.org/docs/configuring/#specifying-parser If that's not enough, let me know what you need. |
@nzakas If that is enough to run ESLint unit tests, I think it should be sufficient. |
It probably depends on how you run the tests, but I think it should work. We set the parser in this file: https://github.com/eslint/eslint/blob/master/conf/eslint.json |
@nzakas only problem is that the suite currently relies on behavior only espree provides. If we're dedicated to doing this, it would make sense for us to begin work on converging the two projects, at least for the parts that aren't add ons like jsx. |
Outside of JSX and |
Right, my point being we'd need a way to ignore those tests. Thoughts? |
@mikesherov It might need a simple pre-processing step, e.g. removing files for unsupported tests. |
Can we add |
Exactly. @jeffmo add at to the description at will, and let's turn it into a checklist :-) |
|
@fkling how can we configure it to use regular esprima? |
@mikesherov: its |
Happy to make the tests configurable, but not immediately sure what the best way to do that is… |
Also, if |
Oh right, I forgot that these CI tests will need to run with master -- maybe we should hold off on adding them to CI until master is close enough to harmony that we can switch esprima-fb over to tracking master (and then perhaps it would make more sense to just make esprima-fb include |
That's what I was thinking as well. |
This is done by checking out each project, run npm install, drop-in a replacement for esprima.js, and run npm test. As of now, this is carried out only as part of Travis CI build. It can be tested manually by: rm -rf downstream npm run downstream Due to some unknown reason, .eslintrc can't exist otherwise it is going to confuse the linting of the downstream project. The workaround is to use custom config file. Refs jquery#1023
This is done by checking out each project, run npm install, drop-in a replacement for esprima.js, and run npm test. As of now, this is carried out only as part of Travis CI build. It can be tested manually by: rm -rf downstream npm run downstream Due to some unknown reason, .eslintrc can't exist otherwise it is going to confuse the linting of the downstream project. The workaround is to use custom config file. Refs jquery#1023
This is done by checking out each project, run npm install, drop-in a replacement for esprima.js, and run npm test. As of now, this is carried out only as part of Travis CI build. It can be tested manually by: rm -rf downstream npm run downstream Due to some unknown reason, .eslintrc can't exist otherwise it is going to confuse the linting of the downstream project. The workaround is to use custom config file. Refs jquery#1023
This was needed for jsfmt, but it's not necessary anymore: rdio/jsfmt#163 Refs jquery#1023
This was needed for jsfmt, but it's not necessary anymore: rdio/jsfmt#163 Refs #1023 Closes gh-1307
Known consumers:
The text was updated successfully, but these errors were encountered: