Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricts the protobuf version to <5.0.0 #413

Merged
merged 1 commit into from
May 31, 2024

Conversation

MuhongGuo
Copy link
Contributor

@MuhongGuo MuhongGuo commented May 14, 2024

Description

Restricts the protobuf version to <5.0.0 in setup.py and closes #412

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Before After
image image

Checklist

  • I have run the pre-commit checks with ./orbit.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the tests with ./orbit.sh --test and they pass
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

piotrklima pushed a commit to piotrklima/IsaacLab that referenced this pull request May 27, 2024
# Description

Renames the `RandomizationManager` to `EventManager` for clarity as the
manager takes care of all kind of events that go beyond pure
randomization (such as resets).

Fixes isaac-sim#413

## Type of change

- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
@Mayankm96 Mayankm96 merged commit 71989e7 into isaac-sim:main May 31, 2024
@Mayankm96
Copy link
Contributor

Thank you for the fix :)

isaac-racine pushed a commit to isaac-racine/orbit that referenced this pull request Jun 5, 2024
# Description

Restricts the protobuf version to <5.0.0 in setup.py and closes
isaac-sim#412

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

| Before | After |
| ------ | ----- |
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/cc41ae19-a22c-472b-8ab8-aa21d2b0b55d)
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/eabf360b-5205-4eb6-a6ca-9403a94ad6d5)
|


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
# Description

Renames the `RandomizationManager` to `EventManager` for clarity as the
manager takes care of all kind of events that go beyond pure
randomization (such as resets).

Fixes isaac-sim#413

## Type of change

- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
# Description

Restricts the protobuf version to <5.0.0 in setup.py and closes
isaac-sim#412

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

| Before | After |
| ------ | ----- |
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/cc41ae19-a22c-472b-8ab8-aa21d2b0b55d)
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/eabf360b-5205-4eb6-a6ca-9403a94ad6d5)
|


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
# Description

Renames the `RandomizationManager` to `EventManager` for clarity as the
manager takes care of all kind of events that go beyond pure
randomization (such as resets).

Fixes isaac-sim#413

## Type of change

- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- This change requires a documentation update

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
# Description

Restricts the protobuf version to <5.0.0 in setup.py and closes
isaac-sim#412

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

| Before | After |
| ------ | ----- |
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/cc41ae19-a22c-472b-8ab8-aa21d2b0b55d)
|
![image](https://github.com/NVIDIA-Omniverse/orbit/assets/17403324/eabf360b-5205-4eb6-a6ca-9403a94ad6d5)
|


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Incompatible version of protobuf is installed
2 participants