Expands observation term scaling to support list of floats #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-roth
requested review from
jsmith-bdai,
Dhoeller19,
Mayankm96 and
kellyguo11
as code owners
Dhoeller19
reviewed
Oct 19, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/manager_term_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
requested changes
Oct 22, 2024
Co-authored-by: Mayank Mittal <[email protected]> Co-authored-by: David Hoeller <[email protected]> Signed-off-by: Pascal Roth <[email protected]>
|
@Mayankm96 test are added |
Dhoeller19
approved these changes
Nov 1, 2024
Signed-off-by: David Hoeller <[email protected]>
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…#1269) # Description Added support to define tuple of floats to scale observation terms by expanding the `ObservationManagerCfg.scale` attribute. ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
adrian-sch
pushed a commit
to adrian-sch/IsaacLab
that referenced
this pull request
Dec 6, 2024
…#1269) # Description Added support to define tuple of floats to scale observation terms by expanding the `ObservationManagerCfg.scale` attribute. ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to define tuple of floats to scale observation terms by expanding the
ObservationManagerCfg.scaleattribute.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there