Fixes net_arch in sb3_ppo_cfg.yaml for Isaac-Lift-Cube-Franka-v0 task
#1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinghengMeng
requested review from
Dhoeller19,
Mayankm96,
jsmith-bdai and
jtigue-bdai
as code owners
|
With this fix, does the environment training work? While you're at it, could you please also check if this bug happens for other sb3 configs? Thank you! |
Mayankm96
changed the title
net_arch in sb3_ppo_cfg.yaml for Isaac-Lift-Cube-Franka-v0 task
Dhoeller19
approved these changes
Oct 28, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…task (isaac-sim#1249) # Description Two changes are made to fix _[Bug Report] sb3_ppo_cfg.yaml not work for Isaac-Lift-Cube-Franka-v0 #1248_: 1. Add `sb3_cfg_entry_point` to `source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka/init.py` 2. Change `net_arch=[32, 32, dict(pi=[256, 128, 64], vf=[256, 128, 64])]` to `net_arch=dict(pi=[256, 128, 64], vf=[256, 128, 64])` in line 19 of `sb3_ppo_cfg.yaml`. Fixes isaac-sim#1248 ## Type of change - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] My changes generate no new warnings
adrian-sch
pushed a commit
to adrian-sch/IsaacLab
that referenced
this pull request
Dec 6, 2024
…task (isaac-sim#1249) # Description Two changes are made to fix _[Bug Report] sb3_ppo_cfg.yaml not work for Isaac-Lift-Cube-Franka-v0 #1248_: 1. Add `sb3_cfg_entry_point` to `source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka/init.py` 2. Change `net_arch=[32, 32, dict(pi=[256, 128, 64], vf=[256, 128, 64])]` to `net_arch=dict(pi=[256, 128, 64], vf=[256, 128, 64])` in line 19 of `sb3_ppo_cfg.yaml`. Fixes isaac-sim#1248 ## Type of change - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] My changes generate no new warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two changes are made to fix [Bug Report] sb3_ppo_cfg.yaml not work for Isaac-Lift-Cube-Franka-v0 #1248:
sb3_cfg_entry_pointtosource/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/manager_based/manipulation/lift/config/franka/init.pynet_arch=[32, 32, dict(pi=[256, 128, 64], vf=[256, 128, 64])]tonet_arch=dict(pi=[256, 128, 64], vf=[256, 128, 64])in line 19 ofsb3_ppo_cfg.yaml.Fixes #1248
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --format