Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability for aio in sub-path access configurations to specify alternate ports #4480

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: ability for aio in sub-path access configurations to specify alternate ports #4480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: add ability for aio containers to specify alternate binding ports
  • Loading branch information
@AndrewBastin
AndrewBastin committed Oct 28, 2024
commit 88ddf5febf4f4d9a82914d436d9280eadd6e80ac
4 changes: 0 additions & 4 deletions aio-multiport-setup.Caddyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,3 @@
:3170 {
reverse_proxy localhost:8080
}

:80 {
respond 404
}
14 changes: 1 addition & 13 deletions aio-subpath-access.Caddyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,7 @@
persist_config off
}

:3000 {
respond 404
}

:3100 {
respond 404
}

:3170 {
reverse_proxy localhost:8080
}

:80 {
:{$HOPP_AIO_ALTERNATE_PORT:80} {
# Serve the `selfhost-web` SPA by default
root * /site/selfhost-web
file_server
Expand Down
2 changes: 2 additions & 0 deletions prod.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ HEALTHCHECK --interval=2s CMD /bin/sh /healthcheck.sh
WORKDIR /dist/backend

CMD ["node", "/usr/src/app/aio_run.mjs"]

# NOTE: Although these ports are exposed, the HOPP_ALTERNATE_AIO_PORT variable can be used to assign a user-specified port
EXPOSE 3170
EXPOSE 3000
EXPOSE 3100
Expand Down