feat: ability for aio in sub-path access configurations to specify alternate ports #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewBastin
force-pushed
the
feat/aio-alternate-port
branch
2 times, most recently
from
c032598
to
95ec5f3
Compare
AndrewBastin
force-pushed
the
feat/aio-alternate-port
branch
from
95ec5f3
to
88ddf5f
Compare
amk-dev
pushed a commit
to amk-dev/hoppscotch
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for users to specify alternate ports for AIO container configurations having sub-path access (single port) configurations. The container normally binds port 80 when using single port access, but port 80 is a privileged port and certain systems (esp. rootless systems like Podman or hardened systems like OpenShift) do not provide root level privileges to allow for binding to port 80.
What's changed
HOPP_AIO_ALTERNATE_PORTwhich is used by Caddy to define which port is to be bound to. No behaviour change for non-AIO containers.Notes
@SanskritiHarmukh do remind me to update the docs to add a section for this.