fix: ensure cross-platform compatibility with file exports #4336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the usage of platform-based API for file exports ensuring compatibility across web and Desktop apps. This accounts for export flows related to collections (REST/GQL) & environments.
Closes #4332 HFE-578.
What's changed
initializeDownloadCollection()
helper function is renamed toinitializeDownloadFile()
and the implementation has been updated to rely on the platform-level APIs instead of the browser-based behaviour. It now returns a promise.hoppscotch-selfhost-web
saveFileWithDialog()
, is updated to prioritise the name if supplied.exportAsJSON
helper function compiling the export business logic for environments is refactored to leverage the above helper function.Notes to reviewers
Please verify all the export flows (individual/bulk at the workspace level) for both the web and Desktop apps.