Skip to content

Ruby 3 support #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cormacrelf wants to merge 2 commits into from
Closed

Ruby 3 support #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5f615
fix ruby 3.0 kwargs
cormacrelf Apr 6, 2021
95df1f3
add ruby 3.0 to CircleCI matrix
cormacrelf Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
#
version: 2.1
orbs:
ruby: circleci/ruby@0.2.2
ruby: circleci/ruby@1.0

shared_steps: &shared_steps
steps:
- run: ruby -v
- checkout
- ruby/load-cache
- run: gem install bundler:2.1.4
- run: gem install bundler:2.2.15
- ruby/install-deps
- ruby/save-cache
- ruby/run-tests
Expand Down Expand Up @@ -59,6 +59,6 @@ workflows:
- test:
matrix:
parameters:
tag: ["2.5", "2.6", "2.7"]
tag: ["2.5", "2.6", "2.7", "3.0"]
requires:
- lint
8 changes: 4 additions & 4 deletions lib/github_changelog_generator/octo_fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ def fetch_closed_issues_and_pr
print "Fetching closed issues...\r" if @options[:verbose]
issues = []
page_i = 0
count_pages = calculate_pages(client, "issues", closed_pr_options)
count_pages = calculate_pages(client, "issues", **closed_pr_options)

iterate_pages(client, "issues", closed_pr_options) do |new_issues|
iterate_pages(client, "issues", **closed_pr_options) do |new_issues|
page_i += PER_PAGE_NUMBER
print_in_same_line("Fetching issues... #{page_i}/#{count_pages * PER_PAGE_NUMBER}")
issues.concat(new_issues)
Expand All @@ -185,7 +185,7 @@ def fetch_closed_pull_requests
page_i = 0
count_pages = calculate_pages(client, "pull_requests", options)

iterate_pages(client, "pull_requests", options) do |new_pr|
iterate_pages(client, "pull_requests", **options) do |new_pr|
page_i += PER_PAGE_NUMBER
log_string = "Fetching merged dates... #{page_i}/#{count_pages * PER_PAGE_NUMBER}"
print_in_same_line(log_string)
Expand Down Expand Up @@ -215,7 +215,7 @@ def fetch_events_async(issues)
issues.each do |issue|
semaphore.async do
issue["events"] = []
iterate_pages(client, "issue_events", issue["number"], preview) do |new_event|
iterate_pages(client, "issue_events", issue["number"], **preview) do |new_event|
issue["events"].concat(new_event)
end
issue["events"] = issue["events"].map { |event| stringify_keys_deep(event.to_hash) }
Expand Down