Skip to content

Conversation

@cormacrelf
Copy link

@cormacrelf
Copy link
Author

Ah whoops, can't believe I wasted time on this when #949 already exists!

@cormacrelf cormacrelf closed this Apr 6, 2021
@cormacrelf
Copy link
Author

While I'm here I can report that I updated the GitHub API VCR cassettes and tried out using actual pull_request objects for pull requests instead of issues. The merge_commit_sha turns out to be less useful than the comment in generator_fetcher.rb anticipated, as for example with https://github.com/github-changelog-generator/changelog_test/pulls/2 the merge_commit_sha points to a commit that no longer exists and this produces incorrect results in various ways. So using the attached events is superior. Hope that helps.

@olleolleolle
Copy link
Collaborator

@cormacrelf If you want to, you can propose a PR, collecting those thoughts into something everyone can read. I'm only the care-taker.

@cormacrelf
Copy link
Author

@olleolleolle it would just be a PR updating a comment, but sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting an error: 'list_issues': wrong number of arguments (given 3, expected 0..2) (ArgumentError) Add Ruby 3 to CI, make it pass

2 participants