Skip to content

Fix bug where vars could not contain commas #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgoedecke merged 1 commit into from
Jul 30, 2025
Merged

Fix bug where vars could not contain commas #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ func NewRunCommand(cfg *command.Config) *cobra.Command {
}

cmd.Flags().String("file", "", "Path to a .prompt.yml file.")
cmd.Flags().StringSlice("var", []string{}, "Template variables for prompt files (can be used multiple times: --var name=value)")
cmd.Flags().StringArray("var", []string{}, "Template variables for prompt files (can be used multiple times: --var name=value)")
cmd.Flags().String("max-tokens", "", "Limit the maximum tokens for the model response.")
cmd.Flags().String("temperature", "", "Controls randomness in the response, use lower to be more deterministic.")
cmd.Flags().String("top-p", "", "Controls text diversity by selecting the most probable words until a set probability is reached.")
Expand All @@ -429,7 +429,7 @@ func NewRunCommand(cfg *command.Config) *cobra.Command {

// parseTemplateVariables parses template variables from the --var flags
func parseTemplateVariables(flags *pflag.FlagSet) (map[string]string, error) {
varFlags, err := flags.GetStringSlice("var")
varFlags, err := flags.GetStringArray("var")
if err != nil {
return nil, err
}
Expand Down
7 changes: 6 additions & 1 deletion cmd/run/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,11 @@ func TestParseTemplateVariables(t *testing.T) {
varFlags: []string{"equation=x = y + 2"},
expected: map[string]string{"equation": "x = y + 2"},
},
{
name: "value with commas",
varFlags: []string{"city=paris, milan", "countries=france, italy, spain"},
expected: map[string]string{"city": "paris, milan", "countries": "france, italy, spain"},
},
{
name: "empty strings are skipped",
varFlags: []string{"", "name=John", " "},
Expand All @@ -475,7 +480,7 @@ func TestParseTemplateVariables(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
flags := pflag.NewFlagSet("test", pflag.ContinueOnError)
flags.StringSlice("var", tt.varFlags, "test flag")
flags.StringArray("var", tt.varFlags, "test flag")

result, err := parseTemplateVariables(flags)

Expand Down
Loading