Fix bug where vars could not contain commas #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the --var flag incorrectly split values containing commas into separate arguments, causing parsing errors when users passed template variables with comma-separated values.
- Changes the flag type from
StringSlicetoStringArrayto prevent automatic comma splitting - Adds comprehensive test coverage for the comma-containing values scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/run/run.go | Updates flag definition and getter from StringSlice to StringArray |
| cmd/run/run_test.go | Adds test case verifying comma-containing values are preserved correctly |
chadfawcett
approved these changes
Jul 30, 2025
Member
chadfawcett
left a comment
chadfawcett
left a comment
There was a problem hiding this comment.
I'm currently debugging why my multiline string isn't working as a variable. This very well may be the culprit.
cschleiden
approved these changes
Jul 30, 2025
Contributor
|
@sgoedecke can you move it to a helper file that I can use as well with the "generate" command? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --var flag was defined as a StringSlice, which treats commas as separators between multiple values. When users passed --var city="paris, milan", it was being split into two separate values:
This PR updates the type to StringArray and adds a test.