Skip to content

Use string format for jsonSchema #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgoedecke merged 4 commits into from
Jul 21, 2025
Merged

Use string format for jsonSchema #73

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1be7d0
Use string format for jsonSchema
sgoedecke Jul 21, 2025
5415563
Update example prompt
sgoedecke Jul 21, 2025
dae6576
Refactor away the double parsing
sgoedecke Jul 21, 2025
ec3ceed
Check return value of Unmarshal
sgoedecke Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check return value of Unmarshal
  • Loading branch information
@sgoedecke
sgoedecke committed Jul 21, 2025
commit ec3ceed9faf27f0ddbf3727d2921a995bda2009d
5 changes: 4 additions & 1 deletion pkg/prompt/prompt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,10 @@ messages:
ResponseFormat: func() *string { s := "json_schema"; return &s }(),
JsonSchema: func() *JsonSchema {
js := &JsonSchema{Raw: jsonSchemaStr}
json.Unmarshal([]byte(jsonSchemaStr), &js.Parsed)
err := json.Unmarshal([]byte(jsonSchemaStr), &js.Parsed)
if err != nil {
t.Fatal(err)
}
return js
}(),
}
Expand Down
Loading