Use string format for jsonSchema #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the JSON schema format in prompt files from YAML object structure to JSON string format, aligning with the Models UI implementation. The change affects how JSON schemas are parsed, validated, and used throughout the codebase.
- Updates JsonSchema struct to store raw JSON string and parsed data separately
- Implements custom YAML unmarshaling to handle JSON string format
- Modifies validation logic to work with parsed schema data
- Updates all test files and examples to use the new JSON string format
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/prompt/prompt.go | Core implementation changes for JsonSchema struct and parsing logic |
| pkg/prompt/prompt_test.go | Updated test cases to use JSON string format and verify parsing |
| examples/json_schema_prompt.yml | Example file converted from YAML to JSON string format |
| cmd/run/run_test.go | Test data updated to use JSON string format |
| cmd/eval/eval_test.go | Test data updated to use JSON string format |
Comments suppressed due to low confidence (2)
pkg/prompt/prompt.go:205
- [nitpick] Removing this helpful comment reduces code readability. Consider keeping comments that explain the purpose of code sections.
if f.ModelParameters.MaxTokens != nil {
pkg/prompt/prompt.go:215
- [nitpick] Removing this helpful comment reduces code readability. Consider keeping comments that explain the purpose of code sections.
if f.ResponseFormat != nil {
stevenlaidlaw
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current json schema support reads the schema from YML, but it should be a string (like in the Models UI). This PR updates the code to expect a string.