Allow visitors to create posts with tags #1221
Conversation
app/actions/post.go
Outdated
| func (input *CreateNewPost) OnPreExecute(ctx context.Context) error { | ||
| input.Tags = make([]*entity.Tag, len(input.TagSlugs)) | ||
| for i, slug := range input.TagSlugs { | ||
| getTag := &query.GetTagBySlug{Slug: slug} | ||
| if err := bus.Dispatch(ctx, getTag); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| input.Tags[i] = getTag.Result | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Good idea to make this part of OnPreExecute. You'll just need to update that comment though.
| BaseURL string `env:"BASE_URL"` | ||
| Locale string `env:"LOCALE,default=en"` | ||
| JWTSecret string `env:"JWT_SECRET,required"` | ||
| PostCreationWithTagsEnabled bool `env:"POST_CREATION_WITH_TAGS_ENABLED,default=false"` |
There was a problem hiding this comment.
Yeah this looks good. I was contemplating if we should have a nested AppFeatures struct, and move this into there so that we could add other things in future, but I think we probably don't need to do that...
|
Looking good. What are you thinking for tests? |
|
On the action part I'm not sure anything is needed, but tell me if I'm wrong. On the handler part I think the needed tests are :
As of now I think the fails are sent as a 404 error, so I will need to investigate on that before making these tests. |
I suppose it depends - if you're handler tests poke the action then that's great, if they mock the action though then you might need some action tests to check the logic around building up the tags for example - see how you get on 👍 |
Issue: #1211
Visitors can now create post with tags