Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick rel-v1.30] Handle edge case as described in issue #328 (#335) #338

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Cherry-pick rel-v1.30] Handle edge case as described in issue #328 (#335) #338

merged 1 commit into from
Nov 25, 2024

Conversation

rishabh-11
Copy link

@rishabh-11 rishabh-11 commented Nov 25, 2024 •
edited
Loading

What this PR does / why we need it:
Cherry-pick of #335

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
IT passed on k8s 1.30.5 AWS cluster

Release note:

The Refresh method resets the priority annotation on machines with priority 1 to match the desired count. Refer to the PR for details on how the desired count is calculated.

@rishabh-11
Handle edge case as described in issue gardener#328 (gardener#335)
fef8ba1 
* handle edge case as described in issue gardener#328

* address review comments
@rishabh-11 rishabh-11 requested review from unmarshall and a team as code owners November 25, 2024 07:11
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2024
unmarshall
unmarshall approved these changes Nov 25, 2024
View reviewed changes
Copy link

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2024
@rishabh-11 rishabh-11 merged commit 7d34b21 into gardener:rel-v1.30 Nov 25, 2024
10 checks passed
@rishabh-11 rishabh-11 deleted the cherry-pick branch November 25, 2024 08:01
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh-11 @unmarshall @gardener-robot-ci-3 @gardener-robot