forked from kubernetes/autoscaler
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle edge case as described in issue #328 #335
Merged
rishabh-11
merged 2 commits into
gardener:machine-controller-manager-provider
from
rishabh-11:fix-edge-case
Nov 25, 2024
Merged
Handle edge case as described in issue #328 #335
rishabh-11
merged 2 commits into
gardener:machine-controller-manager-provider
from
rishabh-11:fix-edge-case
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Nov 14, 2024
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 14, 2024
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 14, 2024
rishabh-11
force-pushed
the
fix-edge-case
branch
from
November 14, 2024 09:50
4609e3c
to
b10e0d9
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 14, 2024
unmarshall
requested changes
Nov 15, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 20, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 20, 2024
unmarshall
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/changes
Needs (more) changes
needs/review
Needs review
labels
Nov 25, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 25, 2024
rishabh-11
merged commit Nov 25, 2024
45e190f
into
gardener:machine-controller-manager-provider
10 checks passed
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Nov 25, 2024
rishabh-11
added a commit
to rishabh-11/autoscaler
that referenced
this pull request
Nov 25, 2024
* handle edge case as described in issue gardener#328 * address review comments
rishabh-11
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the
Refresh
method of CA to reset the priority annotation on the machine objects only if the number of annotated machines is more than desired. The desired count istotalMachines - mcd.Spec.Replicas
.Terminating
andFailed
machines are excluded while calculating the total number of annotated machines.Which issue(s) this PR fixes:
Fixes #328
Special notes for your reviewer:
Release note: