Skip to content

Conversation

@ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 18, 2024

Update: This now completes all flags and all commands. So, tmux if-shell -<TAB> now works as well.

Original description: For example, tmux shell<tab> now completes to if-shell and run-shell, though
no additional information is provided.

This PR and #10854 complement each other, but either could be used independently from the other if necessary.

TODOs:

  • (n/a) Changes to fish usage are reflected in user documentation/manpages.
  • (n/a) Tests have been added for regressions fixed
  • (n/a) User-visible changes noted in CHANGELOG.rst

@ilyagr ilyagr marked this pull request as ready for review November 18, 2024 07:43
@ilyagr ilyagr changed the title completions/tmux: complete all commands when tmux lscm works completions/tmux: complete all tmux subcommands when tmux lscm works Nov 18, 2024
@ilyagr ilyagr force-pushed the tmux-allcommands branch 3 times, most recently from cf2d2a7 to 760ee22 Compare November 18, 2024 07:48
@ilyagr ilyagr changed the title completions/tmux: complete all tmux subcommands when tmux lscm works completions/tmux: dynamic completions for all tmux subcommands and flags when tmux lscm works Nov 18, 2024
@ilyagr ilyagr changed the title completions/tmux: dynamic completions for all tmux subcommands and flags when tmux lscm works completions/tmux: dynamic completions for all tmux subcommands and flags with tmux lscm Nov 19, 2024
@ilyagr ilyagr changed the title completions/tmux: dynamic completions for all tmux subcommands and flags with tmux lscm completions/tmux: dynamic completions for all tmux subcommands and flags using tmux lscm Dec 19, 2024
For example, `tmux shell<tab>` now completes to `if-shell` and
`run-shell`, though no additional information is provided.
These dynamic completions are exhaustive, but not as well-documented or
as ergonomic as the manual completions. So, any manual completions
should override them.
ilyagr added a commit to ilyagr/fish-shell that referenced this pull request Jan 20, 2025
This documents some non-argument options for the window and panes
commands. The choice of what to document is somewhat arbitrary,
this commit is biased towards options that I find confusing or
misleading without documentation (is `-a` "all" or "after"?)
and the command that seem more useful to me.

I also didn't cover the options that would be covered by
fish-shell#10855 (though this PR can be used independently).
@zanchey
Copy link
Member

zanchey commented Jan 28, 2025

Cool, this works well for me.

@zanchey zanchey self-assigned this Jan 28, 2025
@zanchey zanchey added this to the fish 4.0 milestone Jan 28, 2025
@zanchey zanchey merged commit 77406dd into fish-shell:master Jan 28, 2025
7 of 8 checks passed
zanchey pushed a commit that referenced this pull request Jan 28, 2025
This documents some non-argument options for the window and panes
commands. The choice of what to document is somewhat arbitrary,
this commit is biased towards options that I find confusing or
misleading without documentation (is `-a` "all" or "after"?)
and the command that seem more useful to me.

I also didn't cover the options that would be covered by
#10855 (though this PR can be used independently). I'm not
sure how much difference this made, it might not matter at
all.
@zanchey
Copy link
Member

zanchey commented Jan 28, 2025

Cherry-picked as d29d63d..9385a25

zanchey pushed a commit that referenced this pull request Jan 28, 2025
This documents some non-argument options for the window and panes
commands. The choice of what to document is somewhat arbitrary,
this commit is biased towards options that I find confusing or
misleading without documentation (is `-a` "all" or "after"?)
and the command that seem more useful to me.

I also didn't cover the options that would be covered by
#10855 (though this PR can be used independently). I'm not
sure how much difference this made, it might not matter at
all.

(cherry picked from commit f241187)
@ilyagr ilyagr deleted the tmux-allcommands branch January 28, 2025 22:38
@faho faho modified the milestones: fish 4.0, fish 4.0-final Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants