Skip to content

Conversation

@ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Nov 18, 2024

These are quite mechanical, but include all the commands (as of tmux
3.5a) in the "Windows and Panes" section of man tmux. For these commands,
I included the target-pane/session/client/window flags and the -F formatstring
flags (but not the less generic flags specific to individual commands).

Nice completion is implemented for those flags where the helper functions
were already implemented previously.

After this, tmux pane<tab> will hopefully be useful.

As a bonus, I listed all the predefined layouts for tmux select-layout.

A few TODOs mention low-hanging fruit for somebody who better
understands fish's complete command syntax (or a future me).

Another piece of low-hanging fruit would be completion for all
the target-window flags. This PR merely lists them.

This PR and #10855 complement each other, but either could be used independently from the other if necessary.

TODOs:

  • (n/a) Changes to fish usage are reflected in user documentation/manpages.
  • (n/a) Tests have been added for regressions fixed
  • (n/a) User-visible changes noted in CHANGELOG.rst

@ilyagr ilyagr force-pushed the tmuxcompl branch 2 times, most recently from 8d72b37 to e0a1c0c Compare November 18, 2024 05:30
@ilyagr ilyagr marked this pull request as ready for review November 18, 2024 05:30
@ilyagr ilyagr force-pushed the tmuxcompl branch 3 times, most recently from 450096a to 016ac82 Compare November 18, 2024 06:00
@ilyagr ilyagr force-pushed the tmuxcompl branch 2 times, most recently from 9846d85 to e636375 Compare November 18, 2024 06:57
These are quite mechanical, but include all the commands (as of tmux
3.5a) in the "Windows and Panes" section of `man tmux`. For these
commands, I included the target-pane/session/client/window flags and the
-F formatstring flags (but not the less generic flags specific to
individual commands).

Nice completion is implemented for those flags where the helper
functions were already implemented previously.

After this, tmux pane<tab> will hopefully be useful.

A few TODOs mention low-hanging fruit for somebody who better
understands fish's `complete` command syntax (or a future me).

Another piece of low-hanging fruit would be completion for all the
target-window flags. This PR merely lists them.
@faho faho merged commit b1064ac into fish-shell:master Dec 29, 2024
7 of 8 checks passed
@faho
Copy link
Member

faho commented Dec 29, 2024

Thanks!

@faho faho added this to the fish 4.1 milestone Dec 29, 2024
@ilyagr ilyagr deleted the tmuxcompl branch December 29, 2024 22:13
@zanchey zanchey modified the milestones: fish 4.1, fish 4.0 Jan 2, 2025
zanchey pushed a commit that referenced this pull request Jan 2, 2025
These are quite mechanical, but include all the commands (as of tmux
3.5a) in the "Windows and Panes" section of `man tmux`. For these
commands, I included the target-pane/session/client/window flags and the
-F formatstring flags (but not the less generic flags specific to
individual commands).

Nice completion is implemented for those flags where the helper
functions were already implemented previously.

After this, tmux pane<tab> will hopefully be useful.

A few TODOs mention low-hanging fruit for somebody who better
understands fish's `complete` command syntax (or a future me).

Another piece of low-hanging fruit would be completion for all the
target-window flags. This PR merely lists them.

(cherry picked from commit b1064ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants