Do not use a promise polyfill on modern setups #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alubbe
force-pushed
the
no-promise-polyfill-on-modern-setups
branch
from
274a84e to
791292a
Compare
alubbe
commented
May 14, 2019
| @@ -121,7 +121,7 @@ CSV.prototype = { | |||
| } | |||
| if (value instanceof Date) { | |||
| if (dateFormat) { | |||
| dateUTC ? moment.utc(value).format(dateFormat) : moment(value).format(dateFormat); | |||
| return dateUTC ? moment.utc(value).format(dateFormat) : moment(value).format(dateFormat); | |||
There was a problem hiding this comment.
I'm pretty sure the missing return here was a bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the most of async/await (performance & stack traces), we need to use the native Promises. This PR does not change that the default export uses
promish, but it does add two new exports that allow access to the modern codebase and native promises. I've also fixed a couple of eslint failures in the affected files.