Skip to content

Add lastColumn property (fixes #1453) #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2020
Merged

Add lastColumn property (fixes #1453) #1487

merged 2 commits into from
Oct 6, 2020

Conversation

FliegendeWurst
Copy link
Contributor

Summary

As suggested by @Jigna-Rathod in #1453, a lastColumn property is added in this PR.

Test plan

I created an automated test in gold.spec.js.

Siemienik
Siemienik reviewed Oct 4, 2020
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if file has empty columns? - Could I ask you to add appropriate test?

@FliegendeWurst
Copy link
Contributor Author

I added another test based on the 1904.xslx file (the first column is empty). As expected, lastColumn is the second column.

@Siemienik Siemienik merged commit d76dc38 into exceljs:master Oct 6, 2020
@DhavalW DhavalW mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FliegendeWurst @Siemienik