Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Improve the match schema #2139

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

AucaCoyan
Copy link
Member

closes #2122

@AucaCoyan
Copy link
Member Author

Now it works 🎉
image

@smeech
Copy link
Collaborator

smeech commented Nov 10, 2024

How do you implement those autocompletion options? I don't see them.

@AucaCoyan
Copy link
Member Author

You can trigger the autcomplete command with Ctrl + Spacebar. It works with most things: python, rust and things that have a schema (yamls and jsons).
The piece of software doing the autocomplete is the LSP (Language Server Protocol)

@AucaCoyan
Copy link
Member Author

How do you implement those autocompletion options? I don't see them.

Oh, sorry, I forgot to tell that you need to use my branch of the schema:

# yaml-language-server: $schema=https://raw.githubusercontent.com/AucaCoyan/espanso/refs/heads/update-matches-schema/schemas/match.schema.json

@AucaCoyan
Copy link
Member Author

With the cursor in shell: I (note the I) and pressing Ctrl Spacebar

@smeech
Copy link
Collaborator

smeech commented Nov 10, 2024

Apologies for not reading your earlier comment properly!

@AucaCoyan
Copy link
Member Author

Don't worry 🤗

@AucaCoyan AucaCoyan marked this pull request as ready for review November 10, 2024 14:41
@AucaCoyan
Copy link
Member Author

It's ready! Please give me your approval before merging it 😊

@smeech
Copy link
Collaborator

smeech commented Nov 10, 2024

One more:

image
The rest of my warnings have cleared using:

# yaml-language-server: $schema=https://raw.githubusercontent.com/AucaCoyan/espanso/refs/heads/update-matches-schema/schemas/match.schema.json

@AucaCoyan
Copy link
Member Author

@smeech ready!
I also added docs to the future developer

@AucaCoyan
Copy link
Member Author

this is not yet working, hold on...

@AucaCoyan AucaCoyan marked this pull request as draft November 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additons to https://github.com/espanso/espanso/blob/dev/schemas/match.schema.json
2 participants