macOS: Remove version check in configure script #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a version check in one of the configure scripts that tests the version of macOS to ensure that the executables that are built can be run on the same computer that built them. The reason for this test has been lost in the mists of time. Presumably there was a good reason for the test when it was first added. Since the test recently has become more complicated because of the introduction of macOS 11.0 and 11.0.1, and is incorrect for some versions of macOS, remove it. If there turns out that the version test would be useful, it can be added back later (but in a less buggy way, preferably using `awk` instead of `sed` to make the version parsing simpler and more accurate).
bjorng
added
team:VM
|
👍 |
|
@andyduong1920 It will be included OTP 23.2 in December. |
Is there any chance to have this fix is released sooner @bjorng, maybe 23.1.4 as MasOS (Big Sur) users can't install 23.1.3 and before that including me 😃 |
fhunleth
added a commit
to fhunleth/kerl
that referenced
this pull request
Dec 10, 2020
This applies erlang/otp@f1044ef which currently exists in `master` to fix an error when configuring the build on OSX Big Sur. See erlang/otp#2871 for details. Fixes kerl#346. Tested with this configuration. - OSX 11.0.1 - OTP 23.1.5
fhunleth
added a commit
to fhunleth/kerl
that referenced
this pull request
Dec 10, 2020
This applies erlang/otp@f1044ef which currently exists in `master` to fix an error when configuring the build on OSX Big Sur. See erlang/otp#2871 for details. Fixes kerl#346. Tested with this configuration. - OSX 11.0.1 - OTP 23.1.4 and 23.1.5
|
Will this be backported to earlier versions, like 22.x? Homebrew helpers like me would like to know. Thanks much! |
vladdu
pushed a commit
to vladdu/kerl
that referenced
this pull request
Jan 26, 2021
This applies erlang/otp@f1044ef which currently exists in `master` to fix an error when configuring the build on OSX Big Sur. See erlang/otp#2871 for details. Fixes kerl#346. Tested with this configuration. - OSX 11.0.1 - OTP 23.1.4 and 23.1.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a version check in one of the configure scripts that
tests the version of macOS to ensure that the executables that
are built can be run on the same computer that built them.
The reason for this test has been lost in the mists of time.
Presumably there was a good reason for the test when it was
first added.
Since the test recently has become more complicated because of the
introduction of macOS 11.0 and 11.0.1, and is incorrect for some
versions of macOS, remove it. If there turns out that the version test
would be useful, it can be added back later (but in a less buggy way,
preferably using
awkinstead ofsedto make the version parsingsimpler and more accurate).