-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the make configuration for macOS 11.0.1 #2865
Conversation
Let me know if I need to open this against |
Yes, please do. (You can edit this pull request to base it on maint. If your commit is currently is based on master, you will also need to rebase it and force-push.) |
1eb9763
to
e303f9f
Compare
Done. :) |
yay!!! Can we get this merged to master and maint ASAP? |
Thank you for the contribution, I hope this appears on |
I have successfully built maint branch with this patch on macOS 11.0.1 |
Both this fix and the previous one for macOS 11.0 in b93b9f9 are wrong and break things for Mac OS X 10.x. See https://bugs.erlang.org/browse/ERL-1407. |
How does it break 10.x? The branch builds fine on my Mac with macOS 10.15.7 as well on a Mac with 10.5.8 in our lab. On which version would it be a problem? I have not yet tested the branch myself on macOS 11.0.1, but @verrchu state above that it works. I am open to suggestions for a better fix of the problem. Perhaps it would be better to remove the version check. I don't remember why we added it in the first place. |
It would be a problem on OS X 10.9 and earlier. See https://bugs.erlang.org/browse/ERL-1407. |
Not on all versions before 10.9. As I said, it built fine on 10.5.8. I'll try to take closer look on this problem before the release of 23.2 to avoid breaking certain version of macOS. For now, this pull request does seem to fix the immediate problem of building on macOS 11.0.1. |
It may build fine, but the test is no longer testing what you think it's testing. |
I see no reason to keep the test, so I'm removing it in #2871. |
This change is needed to ensure that we're able to configure make on macOS 11.0.1.
A smilar fix was applied for 11.0 in #2700
Main changes:
Verified via ./otp_build tests