-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate kafka consumer bridge to source + connector #12595
Merged
zhongwencool
merged 4 commits into
emqx:master
from
thalesmg:kafka-consumer-source-m-20240223
Mar 1, 2024
Merged
feat: migrate kafka consumer bridge to source + connector #12595
zhongwencool
merged 4 commits into
emqx:master
from
thalesmg:kafka-consumer-source-m-20240223
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
kafka-consumer-source-m-20240223
branch
3 times, most recently
from
February 26, 2024 20:00
8a49e4f
to
4feb28c
Compare
thalesmg
commented
Feb 26, 2024
@@ -775,7 +775,7 @@ handle_update(ConfRootKey, Id, Conf0) -> | |||
Id, | |||
case emqx_bridge_v2:lookup(ConfRootKey, BridgeType, BridgeName) of | |||
{ok, _} -> | |||
RawConf = emqx:get_raw_config([bridges, BridgeType, BridgeName], #{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
thalesmg
force-pushed
the
kafka-consumer-source-m-20240223
branch
2 times, most recently
from
February 26, 2024 20:13
4bcafb4
to
37a43f0
Compare
thalesmg
commented
Feb 26, 2024
@@ -205,7 +207,11 @@ bridge_configs_to_transform( | |||
emqx_utils_maps:deep_get( | |||
[<<"actions">>, to_bin(BridgeType), to_bin(BridgeName)], | |||
RawConfig, | |||
undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing this: #12486 (comment)
9 tasks
thalesmg
force-pushed
the
kafka-consumer-source-m-20240223
branch
2 times, most recently
from
February 26, 2024 21:19
a6cf725
to
dd82eac
Compare
thalesmg
commented
Feb 27, 2024
thalesmg
force-pushed
the
kafka-consumer-source-m-20240223
branch
4 times, most recently
from
February 27, 2024 20:51
4c7c5d6
to
116f87f
Compare
thalesmg
force-pushed
the
kafka-consumer-source-m-20240223
branch
from
February 27, 2024 20:52
116f87f
to
6b9844a
Compare
zhongwencool
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-11848
Release version: e5.6
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update