Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert gcp_pubsub_consumer to connector/source #12486

Merged
merged 4 commits into from
Feb 21, 2024
Merged

feat: convert gcp_pubsub_consumer to connector/source #12486

merged 4 commits into from
Feb 21, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Feb 6, 2024 •
edited
Loading

Fixes https://emqx.atlassian.net/browse/EMQX-11471

Release version: v/e5.6

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the gcp-consumer-source-m-20240205 branch 2 times, most recently from 664f898 to 55732a6 Compare February 7, 2024 12:58
@thalesmg
Copy link
Contributor Author

thalesmg commented Feb 7, 2024 •
edited
Loading

  • TODO: add some v2 schema smoke tests

@thalesmg
Copy link
Contributor Author

thalesmg commented Feb 7, 2024 •
edited
Loading

Fixed here: #12595

@thalesmg
Copy link
Contributor Author

thalesmg commented Feb 7, 2024 •
edited
Loading

  • TODO: should use emqx_action_info:action_type_to_connector_type(BridgeType) to get connector type prior to this call

    emqx/apps/emqx_bridge/src/emqx_bridge_v2.erl

    Line 684 in 82850b5

    ConnectorResId = emqx_connector_resource:resource_id(BridgeType, ConnectorName),

@thalesmg thalesmg force-pushed the gcp-consumer-source-m-20240205 branch 2 times, most recently from 7c782d5 to b76dfc1 Compare February 8, 2024 19:32
@thalesmg thalesmg force-pushed the gcp-consumer-source-m-20240205 branch from b76dfc1 to b7ddf0b Compare February 19, 2024 17:42
@thalesmg thalesmg force-pushed the gcp-consumer-source-m-20240205 branch from b7ddf0b to 146d89b Compare February 19, 2024 20:54
@thalesmg thalesmg marked this pull request as ready for review February 20, 2024 15:37
@thalesmg thalesmg requested review from JimMoen and a team as code owners February 20, 2024 15:37
zmstone
zmstone previously approved these changes Feb 20, 2024
View reviewed changes
rel/i18n/emqx_bridge_gcp_pubsub_consumer_schema.hocon Outdated Show resolved Hide resolved
@thalesmg @zmstone
docs: improve descriptions
411e580 
Co-authored-by: Zaiming (Stone) Shi <[email protected]>
kjellwinblad
kjellwinblad approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kjellwinblad kjellwinblad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thalesmg thalesmg merged commit 4118fcf into emqx:master Feb 21, 2024
166 checks passed
@thalesmg thalesmg deleted the gcp-consumer-source-m-20240205 branch February 21, 2024 13:06
HJianBo
HJianBo reviewed Feb 26, 2024
View reviewed changes
apps/emqx_bridge_gcp_pubsub/src/emqx_bridge_gcp_pubsub_consumer_action_info.erl
%% The new schema has a single pubsub topic, so we take it from topic mapping when
%% converting from v1.
maybe_set_pubsub_topic(#{<<"topic_mapping">> := [#{<<"pubsub_topic">> := Topic} | _]} = Params) ->
Params#{<<"topic">> => Topic};
Copy link
Member

@HJianBo HJianBo Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we need some warning logs for our users?

And, we also need to add this breaking change log.

@thalesmg thalesmg mentioned this pull request Feb 26, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo left review comments

@kjellwinblad kjellwinblad kjellwinblad approved these changes

@zmstone zmstone zmstone approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thalesmg @zmstone @kjellwinblad @HJianBo