-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/273 #291
Bug/273 #291
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #291 +/- ##
==========================================
- Coverage 82.74% 82.65% -0.10%
==========================================
Files 126 124 -2
Lines 3710 3695 -15
Branches 481 479 -2
==========================================
- Hits 3070 3054 -16
- Misses 492 493 +1
Partials 148 148
Continue to review full report at Codecov.
|
@DarthPedro I think I have found the problem. When we called this ClaimsPrincipal ctor it actually throws away our FakePrincple and creates its own. I have changed the code in this PR to just use the ClaimsIdentity and ClaimsPrinciple instead, and it seems to work correctly, with the new and existing tests. Can you give this a quick look over and see if I have missed anything? |
Hi @egil, |
Pull request description
Fixes #273
PR meta checklist
DEV
branch.Content checklist