doveadm: doveadm-print-json - Prevent crash on subsequent user prints

Move closing the final json array delimiter to the deinitialization routine instead of on flush.
dovecot · Oct 10, 2024 · 5f66f3f · 5f66f3f
1 parent 5d1592b
commit 5f66f3f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/doveadm/doveadm-print-json.c b/src/doveadm/doveadm-print-json.c
@@ -117,12 +117,13 @@ static void doveadm_print_json_flush(void)
 
 	if (ctx.json_output == NULL)
 		doveadm_print_json_init_output();
-	json_ostream_nascend_array(ctx.json_output);
 	json_ostream_nflush(ctx.json_output);
 }
 
 static void doveadm_print_json_deinit(void)
 {
+	if (ctx.json_output != NULL)
+		json_ostream_nascend_array(ctx.json_output);
 	json_ostream_destroy(&ctx.json_output);
 	pool_unref(&ctx.pool);
 }