Skip to content

[27.x backport] test-fixes #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2025
Merged

[27.x backport] test-fixes #5720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b340f4
TestRunCopyFromContainerToFilesystem: use Tar without options
thaJeztah Dec 23, 2024
074820d
Fix cp test to separate source and destination
dmcgowan Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
TestRunCopyFromContainerToFilesystem: use Tar without options 
Just a minor cleanup; use archive.Tar as we're not using other
options here.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit a8f83d5)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
@thaJeztah
thaJeztah committed Jan 3, 2025
commit 8b340f4e5c01c610b7be6c30b17464f677d62e2e
2 changes: 1 addition & 1 deletion cli/command/container/cp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func TestRunCopyFromContainerToFilesystem(t *testing.T) {
cli := test.NewFakeCli(&fakeClient{
containerCopyFromFunc: func(ctr, srcPath string) (io.ReadCloser, container.PathStat, error) {
assert.Check(t, is.Equal("container", ctr))
readCloser, err := archive.TarWithOptions(destDir.Path(), &archive.TarOptions{})
readCloser, err := archive.Tar(destDir.Path(), archive.Uncompressed)
return readCloser, container.PathStat{}, err
},
})
Expand Down