Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] test-fixes #5720

Merged

Conversation

thaJeztah
Copy link
Member

thaJeztah and others added 2 commits January 3, 2025 13:56
Just a minor cleanup; use archive.Tar as we're not using other
options here.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit a8f83d5)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Currently the cp will tar from the same directory it will untar into
simultaneously. There is a race between reading the file and truncating
the file for write, however, the race will not show up with a large
enough buffer on the tar side if buffered before the copy begins.

Also removes the unnecessary deferred removal, the removal is handled by
cleanup and respects the no cleanup env.

Signed-off-by: Derek McGowan <[email protected]>
(cherry picked from commit 8c0cb30)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 27.5.0 milestone Jan 3, 2025
@thaJeztah thaJeztah self-assigned this Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (0e053a5) to head (074820d).
Report is 4 commits behind head on 27.x.

Additional details and impacted files
@@           Coverage Diff           @@
##             27.x    #5720   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files         346      346           
  Lines       29322    29322           
=======================================
  Hits        17178    17178           
  Misses      11171    11171           
  Partials      973      973           

@thaJeztah thaJeztah merged commit e0e9fea into docker:27.x Jan 3, 2025
102 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_fix-container-cp-test branch January 3, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants