Skip to content

Fix edge case with rendering children as number 0 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dburles wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix edge case with rendering children as number 0 #18

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88278a1
fix edge case with rendering children as number 0
dburles Mar 18, 2019
015b1b9
don't attempt to render null children
dburles Mar 18, 2019
b3bd6bc
Merge branch 'master' into master
developit May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into master
  • Loading branch information
@developit
developit authored May 23, 2019
commit b3bd6bc715a5e833b7dfb4ec72c38181cbddd624
16 changes: 16 additions & 0 deletions test/vhtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,20 @@ describe('vhtml', () => {
'<div><span></span></div>'
);
});

it('should support string fragments', () => {
expect(
h(null, null, "foo", "bar", "baz")
).to.equal(
'foobarbaz'
);
});

it('should support element fragments', () => {
expect(
h(null, null, <p>foo</p>, <em>bar</em>, <div class="qqqqqq">baz</div>)
).to.equal(
'<p>foo</p><em>bar</em><div class="qqqqqq">baz</div>'
);
});
});
You are viewing a condensed version of this merge commit. You can view the full changes here.