Skip to content

Fix edge case with rendering children as number 0 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dburles wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix edge case with rendering children as number 0 #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88278a1
fix edge case with rendering children as number 0
dburles Mar 18, 2019
015b1b9
don't attempt to render null children
dburles Mar 18, 2019
b3bd6bc
Merge branch 'master' into master
developit May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix edge case with rendering children as number 0
  • Loading branch information
@dburles
dburles committed Mar 18, 2019
commit 88278a1fb47f93edb40e974ab4eaf6923169f4a4
2 changes: 1 addition & 1 deletion src/vhtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default function h(name, attrs) {

while (stack.length) {
let child = stack.pop();
if (child) {
if (child !== undefined) {
if (child.pop) {
for (let i=child.length; i--; ) stack.push(child[i]);
}
Expand Down
11 changes: 11 additions & 0 deletions test/vhtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,15 @@ describe('vhtml', () => {
'<div class="my-class" for="id"></div>'
);
});

it('should render a child of 0', () => {
function Child ({ children }) {
return <span>{children}</span>;
}
expect(
<div><Child>{0}</Child></div>
).to.equal(
'<div><span>0</span></div>'
);
});
});