fix(core): remove async op inlining optimization #17899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Feb 23, 2023
ramnivas
added a commit
to exograph/exograph
that referenced
this pull request
Mar 23, 2023
The major change is how we invoke async functions (see denoland/deno#17899). Without the change (for example, `core.ops.op_claytip_execute_query_priv(query_string, variables, context_override)` to `core.opAsync("op_claytip_execute_query_priv", query_string, variables, context_override)`, we see failures with error message: "ERROR payas_deno::deno_module > err=TypeError: invalid promise id: expected type `v8::data::Integer`, got `v8::data::Value`"
ramnivas
added a commit
to exograph/exograph
that referenced
this pull request
Mar 23, 2023
The major change is in how we invoke async functions (see denoland/deno#17899), so instead of, for example `core.ops.op_claytip_execute_query_priv(query_string, variables, context_override)`, we use `core.ops.op_claytip_execute_query_priv(query_string, variables, context_override)`. Without this change we see failures with an error message: "ERROR payas_deno::deno_module > err=TypeError: invalid promise id: expected type `v8::data::Integer`, got `v8::data::Value`" Also, add a unit test for invoking Rust async operation through JavaScript to test/debug such issues in payas-deno itself.
shadaj
pushed a commit
to exograph/exograph
that referenced
this pull request
Apr 20, 2023
The major change is in how we invoke async functions (see denoland/deno#17899), so instead of, for example `core.ops.op_claytip_execute_query_priv(query_string, variables, context_override)`, we use `core.ops.op_claytip_execute_query_priv(query_string, variables, context_override)`. Without this change we see failures with an error message: "ERROR payas_deno::deno_module > err=TypeError: invalid promise id: expected type `v8::data::Integer`, got `v8::data::Value`" Also, add a unit test for invoking Rust async operation through JavaScript to test/debug such issues in payas-deno itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16428
Fixes #16535
Runtime generation of async op wrappers contributed to increased startup time and core became unusable with
--disallow-code-generation-from-stringsflag. The optimization only affects very small microbenchmarks so this revert will not cause any regressions.