perf(core): generate inlined wrappers for async ops #16428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+bench |
|
⏳ Provisioning metal... id: Use |
|
piscisaureus
approved these changes
Oct 27, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Oct 27, 2022
littledivy
added a commit
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8's JIT can do a better job knowing the argument count and also enable fast call path (in future).
This also lets us call async ops without
opAsync:this patch: 4405286 ops/sec
main: 3508771 ops/sec