Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(ops): Fast zero copy string arguments (#16777)" #17063

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Revert "feat(ops): Fast zero copy string arguments (#16777)" #17063

merged 1 commit into from
Dec 15, 2022

Conversation

bartlomieju
Copy link
Member

This reverts commit 9b2b8df.

Closes dsherret/ts-morph#1372
Closes #16979

dsherret
dsherret approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice to know exactly why this caused this error. Maybe something in rusty_v8?

@bartlomieju
Copy link
Member Author

I will debug it after we release v1.29.1

@dsherret dsherret enabled auto-merge (squash) December 15, 2022 15:18
@dsherret dsherret merged commit 585ec12 into denoland:main Dec 15, 2022
@bartlomieju bartlomieju deleted the revert_16777 branch December 15, 2022 15:27
@dsherret dsherret mentioned this pull request Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest Deno release (1.29.0) breaks ts-morph Uncatchable error after repeated calls to Deno.statSync
3 participants
@bartlomieju @dsherret @littledivy