Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move redshift, snowflake, bigquery plugins #3969

Merged
merged 6 commits into from
Oct 2, 2021
Merged

Conversation

jtcohen6
Copy link
Contributor

It seems such a waste of time
If that's what it's all about
Mama if that's movin' up
Then I'm movin' out
I'm movin' out

These are private for now, while we set up automated tests and do some repo housekeeping:

@cla-bot cla-bot bot added the cla:yes label Sep 29, 2021
@jtcohen6 jtcohen6 force-pushed the pull-out-rs-sf-bq branch 2 times, most recently from d577f40 to 581d100 Compare September 29, 2021 10:34
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Sep 29, 2021

We ran + passed 455 integration tests on Postgres, the same number as on the develop branch currently.

I've commented out non-Postgres RPC integration tests. This is just a temporary move until #3755.

@jtcohen6
Copy link
Contributor Author

Planned merge: Saturday, Oct 2. We're freezing all code Friday, October 1 @ 5 pm ET. We'll incorporate any updates to adapters + integration tests in the dbt-redshift, dbt-snowflake, and dbt-bigquery repos, and then merge this PR.

Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Kyle Wigley and others added 6 commits October 2, 2021 17:22
Start moving unit tests

fix typo; rm breakpoints

rm references to redshift

rm all references to redshift except `integration/100_rpc_test` 🙁

cleanup CI

fix tests!

fix docs test bc of schema version change
Continue pulling apart Snowflake tests

Fixups

Rip out even more
@jtcohen6 jtcohen6 merged commit 3789acc into develop Oct 2, 2021
@jtcohen6 jtcohen6 deleted the pull-out-rs-sf-bq branch October 2, 2021 17:30
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* Consolidate dbt-redshift

Start moving unit tests

fix typo; rm breakpoints

rm references to redshift

rm all references to redshift except `integration/100_rpc_test` 🙁

cleanup CI

fix tests!

fix docs test bc of schema version change

* Consolidate dbt-snowflake

Continue pulling apart Snowflake tests

Fixups

Rip out even more

* Consolidate dbt-bigquery

* Rm redshift, snowflake, bigquery from plugins/

* Comment out rs, sf, bq profiles in 100_rpc_test

* Add changelog, readme notes

Co-authored-by: Kyle Wigley <[email protected]>

automatic commit by git-black, original commits:
  3789acc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants