-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rip out rpc server code #3755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rip out rpc server code #3755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4fa5e04
to
7b139a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we got all the details I can think of. Thanks for digging into the architecture doc too!
7b139a5
to
49e87bb
Compare
there are few more places where we refer to rpc in dbt-core
|
a6a9c53
to
20883fd
Compare
RIP 👻 |
* rm rpc specfic code, still more references to rpc to clean up (rpc_method, integration tests, etc.) * rm move references to rpc * rm tests against rpc server * rm more rpc files * more code! * sorry! automatic commit by git-black, original commits: 6e2df00
resolves #3675
Description
This PR removed the builtin dbt rpc server.
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.