Skip to content

Rip out rpc server code #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2021
Merged

Rip out rpc server code #3755

merged 6 commits into from
Oct 8, 2021

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Aug 16, 2021

resolves #3675

Description

This PR removed the builtin dbt rpc server.

  • remove references to builtin rpc server.
  • remove tests against rpc server

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Aug 16, 2021
@kwigley kwigley temporarily deployed to Postgres August 16, 2021 15:01 Inactive
@kwigley kwigley temporarily deployed to Bigquery August 16, 2021 15:01 Inactive
@kwigley kwigley temporarily deployed to Bigquery August 16, 2021 15:01 Inactive
@kwigley kwigley temporarily deployed to Snowflake August 16, 2021 15:01 Inactive
@kwigley kwigley temporarily deployed to Redshift August 16, 2021 15:01 Inactive
@kwigley kwigley temporarily deployed to Redshift August 16, 2021 15:01 Inactive
@kwigley kwigley closed this Aug 16, 2021
@kwigley kwigley reopened this Aug 16, 2021
@kwigley kwigley temporarily deployed to Postgres August 16, 2021 21:19 Inactive
@kwigley kwigley temporarily deployed to Bigquery August 16, 2021 21:19 Inactive
@kwigley kwigley temporarily deployed to Bigquery August 16, 2021 21:19 Inactive
@kwigley kwigley temporarily deployed to Redshift August 16, 2021 21:19 Inactive
@kwigley kwigley temporarily deployed to Redshift August 16, 2021 21:19 Inactive
@kwigley kwigley temporarily deployed to Snowflake August 16, 2021 21:19 Inactive
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwigley kwigley force-pushed the compat-dbt-rpc branch 2 times, most recently from 4fa5e04 to 7b139a5 Compare August 30, 2021 14:47
@kwigley kwigley closed this Aug 30, 2021
@kwigley kwigley reopened this Aug 30, 2021
@kwigley kwigley self-assigned this Sep 15, 2021
@kwigley kwigley marked this pull request as ready for review October 7, 2021 15:14
@nathaniel-may nathaniel-may self-requested a review October 7, 2021 15:41
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we got all the details I can think of. Thanks for digging into the architecture doc too!

@kwigley
Copy link
Contributor Author

kwigley commented Oct 7, 2021

there are few more places where we refer to rpc in dbt-core

core/dbt/tracking.py
30:RPC_REQUEST_SPEC = 'iglu:com.dbt/rpc_request/jsonschema/1-0-1'
328:def track_rpc_request(options):
331:        'Cannot track rpc requests when active user is None'
336:        action='rpc_request',

core/dbt/node_types.py
13:    RPCCall = 'rpc'

core/dbt/main.py
361:    sub.set_defaults(cls=init_task.InitTask, which='init', rpc_method=None)
376:        rpc_method='build'
433:    sub.set_defaults(cls=clean_task.CleanTask, which='clean', rpc_method=None)
455:    sub.set_defaults(cls=debug_task.DebugTask, which='debug', rpc_method=None)
467:    sub.set_defaults(cls=deps_task.DepsTask, which='deps', rpc_method='deps')
489:                     rpc_method='snapshot')
526:    run_sub.set_defaults(cls=run_task.RunTask, which='run', rpc_method='run')
540:                     rpc_method='compile')
554:                     rpc_method='parse')
565:                              which='generate', rpc_method='docs.generate')
690:                          rpc_method='seed')
710:                           rpc_method=None)
747:    sub.set_defaults(cls=test_task.TestTask, which='test', rpc_method='test')
780:        rpc_method='source-freshness',
804:    sub.set_defaults(cls=list_task.ListTask, which='list', rpc_method=None)
880:                     which='run-operation', rpc_method='run-operation')

core/dbt/flags.py
10:# It also gets set in main.py and in set_from_args because the rpc server

core/dbt/parser/manifest.py
1129:# This is called in task.rpc.sql_commands when a "dynamic" node is
1143:# This is called in task.rpc.sql_commands when a "dynamic" node is

core/dbt/contracts/graph/parsed.py
241:        elif resource_type == 'rpc':

@owlas
Copy link

owlas commented Oct 8, 2021

RIP 👻

@leahwicz leahwicz merged commit 6e2df00 into develop Oct 8, 2021
@leahwicz leahwicz deleted the compat-dbt-rpc branch October 8, 2021 15:43
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* rm rpc specfic code, still more references to rpc to clean up (rpc_method, integration tests, etc.)

* rm move references to rpc

* rm tests against rpc server

* rm more rpc files

* more code!

* sorry!

automatic commit by git-black, original commits:
  6e2df00
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* rm rpc specfic code, still more references to rpc to clean up (rpc_method, integration tests, etc.)

* rm move references to rpc

* rm tests against rpc server

* rm more rpc files

* more code!

* sorry!

automatic commit by git-black, original commits:
  0e01064
  1a0df17
  6e2df00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC spilt code complete
4 participants