Skip to content

docs: Add versioned sidebar #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2023
Merged

docs: Add versioned sidebar #50

merged 2 commits into from
Aug 29, 2023

Conversation

yoonhyejin
Copy link
Collaborator

No description provided.

@yoonhyejin yoonhyejin requested a review from hsheth2 August 29, 2023 03:34
@yoonhyejin yoonhyejin changed the title Add versioned sidebar docs: Add versioned sidebar Aug 29, 2023
@yoonhyejin yoonhyejin mentioned this pull request Aug 29, 2023
Merged
5 tasks
hsheth2
hsheth2 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

an alternative would be to include the sidebar.json in the tar.gz file, but don't think it makes a big difference so up to you on how to implement it

@yoonhyejin yoonhyejin merged commit c28730b into main Aug 29, 2023
@yoonhyejin yoonhyejin deleted the versioned_sidebar branch August 29, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2